[SFCA -- Trust/Security][Implementation] Address potential security vulnerabilities in NPSP (CRLP) #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,9 @@ | |||
| * @description Lightning Component Server Controller for the Rollups UI page CRLP_Setup. | |||
| */ | |||
|
|
|||
| // Adding custom rule to avoid this class being scanned by the SFCA scanner since we will not enforce FLS for | |||
There was a problem hiding this comment.
This is a useful comment. Should it be included in CMT_FilterRule_SEL as well?
There was a problem hiding this comment.
Agreed. Just added!
lparrott
approved these changes
Jun 8, 2022
npsp-reedestockton
approved these changes
Jun 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a code notation to bypass the customized rollup service when the SFCA scanner is executed on the NPSP code base since we don't want all CRLP operations to execute in a system context regardless of user permissions.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata